Attention is currently required from: Anjaneya "Reddy" Chagam, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Tim Chu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60543 )
Change subject: soc/intel/skylake: Move FSP_HYPERTHREADING to common Intel Kconfig
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/60543/comment/46393516_1ba7b9d6
PS6, Line 144: if HAVE_HYPERTHREADING
use "depends on".
Done
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60543/comment/6c823235_43c4e210
PS6, Line 38: HAVE_HYPERTHREADING
Can you select this in patches that hook it up? It looks like only skylake consumes CONFIG_FSP_HYPER […]
Makes sense, yes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I892d48b488cbf828057f0e9be9edc4352c58bbe7
Gerrit-Change-Number: 60543
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 04 May 2022 07:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment