3 Feb
2022
3 Feb
'22
10:08 p.m.
Attention is currently required from: Martin Roth, Matt DeVillier. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 )
Change subject: payloads/tianocore: Rework Makefile ......................................................................
Patch Set 12:
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61550/comment/5acb5635_f78b13ff PS12, Line 89: rm -rf $(project_dir)
This seems a little dangerous to me. […]
That's a very good idea - set project_dir to: $(word 4,$(subst /, ,$(CONFIG_TIANOCORE_REPOSITORY)))+$(word 2,$(subst /, ,$(CONFIG_TIANOCORE_TAG_OR_REV))) i.e. mrchromebox+uefipayload_202202
--
To view, visit https://review.coreboot.org/c/coreboot/+/61550
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic52e0afa7744f4a902274c41aed59ca23fd9f5fc
Gerrit-Change-Number: 61550
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 22:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment