[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Call pci_dev_request_bus_master() from .final ops

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44512 )

Change subject: soc/intel/common: Call pci_dev_request_bus_master() from .final ops
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG@15 
PS2, Line 15: access
> Thanks for the detailed inputs, Nico! They are helpful to understand the history here. […]

There's CB:42460 which replaces all instances where enabling Bus Master was deemed to be unnecessary with `pci_dev_request_bus_master`. This is an intermediate step to allow "busmasterless" (I just made this name up) coreboot while preserving the original behavior by default, in case it breaks something.

If depthcharge tries to use DMA without enabling Bus Master first, then I'd say depthcharge has a bug.