View Change
1 comment:
Commit Message:
Patch Set #2, Line 15: access
Thanks for the detailed inputs, Nico! They are helpful to understand the history here. […]
There's CB:42460 which replaces all instances where enabling Bus Master was deemed to be unnecessary with `pci_dev_request_bus_master`. This is an intermediate step to allow "busmasterless" (I just made this name up) coreboot while preserving the original behavior by default, in case it breaks something.
If depthcharge tries to use DMA without enabling Bus Master first, then I'd say depthcharge has a bug.
To view, visit change 44512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife65f6029d2f966e321f616e85f59f4c37c42145
Gerrit-Change-Number: 44512
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Mon, 14 Sep 2020 10:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subi.banik@gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Gerrit-MessageType: comment