Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: drivers/vpd: Add a function that reads BIOS version from a VPD variable ......................................................................
Patch Set 6:
Well, no, I think if you *do* want to update the version number after the firmware image is finalized, putting it in VPD is probably the right thing after all. I guess this is a bit up to personal interpretation but I would consider the CBFS as the actual firmware (because all the stage binaries with the actual code are in there, and they're all mixed in together with other CBFS files)
But shouldn't the "version" be part of actual firmware?
I still think it would be easier to just set the version number at build time instead. If you want to test different release candidates
Sounds like a different process. In Chrome OS, we do "tag a new release version and then test it", and they are "testing binaries then tag for new release".
Something I'd like to mention: when testing auto update, we had similar script in fm_and_key_version_test_prep.sh that will search and replace version string directly, but that's only for testing.