HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39125 )
Change subject: mb/kontron/986lcd-m: Use `winbond_enable_serial()` ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39125/1/src/mainboard/kontron/986lc... File src/mainboard/kontron/986lcd-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/39125/1/src/mainboard/kontron/986lc... PS1, Line 107: pnp_enter_conf_state(dev); : : pnp_set_logical_device(dev); /* Set COM3 to sane non-conflicting values */ : pnp_set_enable(dev, 0); : pnp_set_iobase(dev, PNP_IDX_IO0, 0x3e8); : pnp_set_irq(dev, PNP_IDX_IRQ0, 11); : pnp_set_enable(dev, 1); same here ?
https://review.coreboot.org/c/coreboot/+/39125/1/src/mainboard/kontron/986lc... PS1, Line 116: pnp_set_logical_device(dev); /* Set COM4 to sane non-conflicting values */ : pnp_set_enable(dev, 0); : pnp_set_iobase(dev, PNP_IDX_IO0, 0x2e8); : pnp_set_irq(dev, PNP_IDX_IRQ0, 10); : pnp_set_enable(dev, 1); ditto?