Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47591 )
Change subject: libpayload/keyboard: Add debug output to all state transitions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47591/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47591/1/payloads/libpayload/drivers... PS1, Line 253: STATE_IGNORE
Where did the comma go?
Removed on purpose because this is supposed to be the last state (as used in the assertion below). I know it's crude, couldn't come up with something better (I tried to add a STATE_LAST, or STATE_COUNT for that, but then GCC got sad and warned I should handle it in the switch()).