Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40222 )
Change subject: payloads/nvramcui: Select USE_OPTION_TABLE ......................................................................
payloads/nvramcui: Select USE_OPTION_TABLE
nvramcui requires use of CMOS for NVRAM configuration, so depend on HAVE_OPTION_TABLE and select USE_OPTION_TABLE to ensure that nvramcui is actually functional when included in a build.
Change-Id: I0595514f636b8ce67bbc789ecc96a93c99068c50 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40222 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/payloads/Kconfig b/payloads/Kconfig index f85dce9..cfb28d6 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -132,7 +132,8 @@ config NVRAMCUI_SECONDARY_PAYLOAD bool "Load nvramcui as a secondary payload" default n - depends on ARCH_X86 + depends on ARCH_X86 && HAVE_OPTION_TABLE + select USE_OPTION_TABLE help nvramcui can be loaded as a secondary payload under SeaBIOS, GRUB, or any other payload that can load additional payloads.