Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36599 )
Change subject: arch/riscv: Use FDT from calling argument when using FIT ......................................................................
Patch Set 5: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c File src/arch/riscv/boot.c:
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c@46 PS1, Line 46: if ((ENV_BOOTBLOCK || ENV_ROMSTAGE) && prog_cbfs_type(prog) == CBFS_TYPE_STAGE)
`else if`
Nope
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c@52 PS1, Line 52: if (ENV_RAMSTAGE) {
`else if` […]
Nope
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c@56 PS1, Line 56: }
Check for FIT is probably the smartest option as it's the only place where it is used at the moment […]
Done
https://review.coreboot.org/c/coreboot/+/36599/4/src/arch/riscv/boot.c File src/arch/riscv/boot.c:
https://review.coreboot.org/c/coreboot/+/36599/4/src/arch/riscv/boot.c@43 PS4, Line 43: PROG_FIT
naah, that's no CBFS type :)
Done