Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47360 )
Change subject: drivers/i2c/dw: Check for TX_ABORT in transfer
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47360/2/src/drivers/i2c/designware/...
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/47360/2/src/drivers/i2c/designware/...
PS2, Line 424: \n
Would it be sufficient to just dump out the content of tx_abort_source?
I think dumping the raw content should be fine. Just helpful to have that extra bit of information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0163fbce55ccc99f677dbb096f67a58d2ef2bda
Gerrit-Change-Number: 47360
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 13:55:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Gerrit-MessageType: comment