Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32651/4/src/soc/amd/common/block/gpio_banks/...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/#/c/32651/4/src/soc/amd/common/block/gpio_banks/...
PS4, Line 53: configure_gevent_smi
I don't recall my exact line of thinking now, seems reasonable to remove this.
This is part of original code, for runtime warning if SMI is disabled. If you remove it and SMI is disabled, it'll not build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cda00210a74de2bd1308ad43e2b867d24a67845
Gerrit-Change-Number: 32651
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Jun 2019 20:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment