[coreboot-gerrit] Change in coreboot[master]: mb/google/helios: Set SPKR_PA_EN PIN high for boot beep

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34705 )

Change subject: mb/google/helios: Set SPKR_PA_EN PIN high for boot beep
......................................................................

Patch Set 1: Code-Review+2
> Patch Set 1:
> > Patch Set 1:
> >
> > Does it need to be enabled in coreboot or can the bootloader apply it?
>
> I guess you mean to say "depthchage" when you are referring "can the bootloader apply it?"
> yes, DC can also do it and i don't believe it has my given timing sequence that SPKR_EN has to be enable "n" ms before sending i2C data and clock. Although we haven't tried moving that code into payload, i'm not big fan of doing GPIO programming in payload :), but certainly can be verified before sending init sequence to codec.