Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................
Patch Set 11: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede...
PS2, Line 20: select DRIVERS_I2C_SX9310
Nit: Move it after Line 5 just so that it is sorted in alphabetical order.
Done
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede...
PS2, Line 149: device i2c 28 on end
Some nits of the tabs above
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f
Gerrit-Change-Number: 43478
Gerrit-PatchSet: 11
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Gwendal Grignou
gwendal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Sep 2020 05:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment