Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46480 )
Change subject: vc/intel/FSP2_0/CPX-SP: add FSPM DIMM watermark option ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46480/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46480/1//COMMIT_MSG@10 PS1, Line 10: FSP binary, but not in Intel's CPX-SP FSP binary. Interesting
https://review.coreboot.org/c/coreboot/+/46480/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/46480/1/src/mainboard/ocp/deltalake... PS1, Line 37: #define FSPM_MEMREFRESHWATERMARK_DEFAULT 1 /* Default value when the VPD variable is not found */
line over 96 characters
I'd just drop the comment
https://review.coreboot.org/c/coreboot/+/46480/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:
PS1: I'd say the changes to this UPD break the ABI when using the Intel CPX-SP FSP binary