Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 25:
(4 comments)
File src/soc/qualcomm/sc7280/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/45205/comment/8968501f_ee8adc9a PS24, Line 8: #define SSRAM_END(addr) SYMBOL(essram, addr)
This was recently changed, please use REGION_START() and REGION_END() for these. See https://review. […]
i will update
https://review.coreboot.org/c/coreboot/+/45205/comment/d976dad2_b8c6e64f PS24, Line 42: FMAP_CACHE(0x1485B400, 2K)
Please fit a CBFS_MCACHE() area of at least 8K in here somewhere, that was also a recent addition. […]
sure i will update
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/e0e33921_64542080 PS24, Line 12: ssize_t ssize;
We've had typo errors with stuff like this before... […]
addressed in below patch https://review.coreboot.org/c/coreboot/+/49013/5/src/soc/qualcomm/sc7280/qcl...
i will update this soc patch individually
https://review.coreboot.org/c/coreboot/+/45205/comment/0d909e90_a8b6c6d8 PS24, Line 15: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX "/pmiccfg",
This API was recently renamed and is now called cbfs_load() with slightly simplified signature (see […]
addressed in below patch https://review.coreboot.org/c/coreboot/+/49013/5/src/soc/qualcomm/sc7280/qcl...
i will update this soc patch individually