Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40531 )
Change subject: mb/google/dedede: Remove pad termination for RAM_STRAP_4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede... PS2, Line 26: if (!google_chromeec_get_board_version(&board_ver)) : half_populated = !gpio_get(GPIO_MEM_CH_SEL);
Both the existing variants (Waddledoo and waddledee) have one phase where the board version is not p […]
Sure, but there will be future derivatives too. Is this something that we want to be the default? Should there be a function:
variant_is_half_populated()
with a weak implementation that returns GPIO_MEM_CH_SEL based on board version check?
Also, are both variants -- waddledoo and waddledee -- missing the external pulls?