Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36546 )
Change subject: soc/intel/icelake: Make use of "all-y" to avoid exclusive stage files in Makefile.inc ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36546/1/src/soc/intel/icelake/Makef... File src/soc/intel/icelake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36546/1/src/soc/intel/icelake/Makef... PS1, Line 22: espi
Is it bad to add some more files like espi.c, gpio.c memmap.c p2sb.c to all-? I understand they are not currently added to verstage and maybe postcar. But, doesn't the linker anyways get rid of unused blocks anyways?
Or are they pulling in other dependencies and causing issues to build?
The linker deals with them properly. IMO for memmap it's bad as that is only meaningful starting from romstage but for other things you listed it would make sense.