Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42826 )
Change subject: gpio_keys: Allows boards to configure different wakeup routes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42826/1/src/drivers/generic/gpio_ke... File src/drivers/generic/gpio_keys/chip.h:
https://review.coreboot.org/c/coreboot/+/42826/1/src/drivers/generic/gpio_ke... PS1, Line 65: unsigned int wake;
If we're updating devictrees why not update 'wake' to 'wake_gpe' for clarity?
Hehe.. I actually thought of that, but got lazy I guess. I will update it.