[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/xeon_sp: Remove PAM lock and unlock operations

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81349?usp=email )

Change subject: soc/intel/xeon_sp: Remove PAM lock and unlock operations
......................................................................

Patch Set 13:

(1 comment)

File src/soc/intel/xeon_sp/util.c:

https://review.coreboot.org/c/coreboot/+/81349/comment/ebfadc9f_57a94fb0 :
PS5, Line 115: lock_pam0123
> Why was this removed? Does FSP lock PAM on all sockets even when CHIPSET_LOCKDOWN_COREBOOT is used?

In UEFI (in bootloader and in FSP), CPX/SKX need the lock, but SPR doesn't need nor do the lock. So based on the alignment, I think it should be okay. We can take this pattern as of now and handle additional requirement later if any. Your opinion?