Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37802 )
Change subject: documentation: Add documentation on setting up mainboard GPIOs
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Nice work, thanks!
There's something that is missing and should really be there: what happens when you configure a GPIO as output but is wired as an input? You risk short-circuiting something!
Another risk: setting an unconnected GPIO as an input without any pulls makes it end up floating, which is undesired.
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start...
File Documentation/getting_started/gpio.md:
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start...
PS2, Line 15: before an SoC's memory
: training step
before initializing the memory
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start...
PS2, Line 42: a list
an array
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I279eec4ed2bb0248a2bdb363fb73b40b8272267f
Gerrit-Change-Number: 37802
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin TerAvest
teravest@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 31 Dec 2019 21:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment