Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45011 )
Change subject: Revert "broadwell: update processor power limits configuration"
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45011/1/src/soc/intel/broadwell/sys...
File src/soc/intel/broadwell/systemagent.c:
https://review.coreboot.org/c/coreboot/+/45011/1/src/soc/intel/broadwell/sys...
PS1, Line 428: config = config_of_soc();
This is where things clash. It seems it was forgotten to actually […]
Indeed. CB:46700 changes the layout of the chip config and broke booting because the PL values were around 1.5 kW. Apparently, the MSR doesn't think such a high value makes sense, a GPF# happens.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e8e000dba8ff09fab4e6f174ab703348dcd6a96
Gerrit-Change-Number: 45011
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 25 Oct 2020 00:26:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment