[coreboot-gerrit] Change in coreboot[master]: mainboard/google: Allow Hatch variants to read SPD data over SMBus

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )

Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/romstage_spd_smbus.c:

https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... 
PS5, Line 25: READ_SMBUS
Did you decide to not use get_spd_smbus()?

https://review.coreboot.org/c/coreboot/+/36449/5/src/mainboard/google/hatch/... 
PS5, Line 42: variant_memory_params
Wouldn't the above configuration get overwritten by the weak implementation of variant_memory_params() in baseboard/memory.c.

Are you intending to provide a stronger implementation for boards using SMBus?