CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43959 )
Change subject: soc/mediatek/mt8192: Add gpio driver ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... File src/soc/mediatek/mt8192/gpio.c:
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 1: /*
need SPDX header
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 20: static void* gpio_find_reg_addr(gpio_t gpio)
please fix this
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 23: switch(gpio.base & 0x0f) {
please fix this
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 23: switch(gpio.base & 0x0f) {
please fix this
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 60: enum
Please align this with "gpio_t gpio".
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 85: enum
Please align this with "gpio_t gpio".
Done
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 116:
Extra blank line.
Done