HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41011 )
Change subject: soc/intel/common: Add ASL for TCSS PCI segment ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
it should fail. why it compile ??
we shouldn't have both of _ADR and _HID at the same time.
https://review.coreboot.org/c/coreboot/+/41011/1/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/pcisegment.asl:
https://review.coreboot.org/c/coreboot/+/41011/1/src/soc/intel/common/block/... PS1, Line 27: Name (_ADR, 0x00000000) ? "ACPI system firmware must supply an _ADR object for each device to enable this. A device object must contain either an _HID object or an _ADR object, but should not contain both."
Advanced Configuration and Power Interface (ACPI) Specification - Version 6.3 - January 2019
page 341 & 342