Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45578 )
Change subject: mb/hp: Add HP EliteBook Folio 9480m ......................................................................
Patch Set 9:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... File Documentation/mainboard/hp/folio_9480m.md:
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... PS8, Line 40: develop
development?
Done
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... PS8, Line 60: 00600000:00bfffff bios
nit: order the layout entries so that they are contiguous
Done
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... PS8, Line 63: res1
what does this stand for? maybe use `reserved`?
That's the name used in ifdtool.c, but it doesn't seem to be used.
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... PS8, Line 93: is lost
does it fall off the board? or is it that it's not visible after resume?
Done
https://review.coreboot.org/c/coreboot/+/45578/8/Documentation/mainboard/hp/... PS8, Line 94: are lost
same
Done
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... PS8, Line 8: kbc1126_enter_conf(); : kbc1126_mailbox_init(); : kbc1126_kbc_init(); : kbc1126_ec_init(); : kbc1126_pm1_init(); : kbc1126_exit_conf();
MEC1322 uses different LDNs for its functions, so this can be dropped now. […]
Done
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... PS8, Line 16: register "c1_acpower" = "1" : register "c1_battery" = "1" : register "c2_acpower" = "3" : register "c2_battery" = "3" : register "c3_acpower" = "5" : register "c3_battery" = "5"
could you please try using `2`, `3` and `9` instead, like google/slippy and google/beltino do? I wan […]
Done
https://review.coreboot.org/c/coreboot/+/45578/8/src/mainboard/hp/folio_9480... PS8, Line 39: sata_port0_gen3_dtle
CB:47234 corrects the values for the existing ports. […]
Done