29 Sep
2020
29 Sep
'20
11:56 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42077 )
Change subject: soc/intel/common/block: Enable PMC IPC driver ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42077/8/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/42077/8/src/soc/intel/common/block/... PS8, Line 247: PMC_IPC_CMD_FIELD(MSI, PMC_IPC_CMD_NO_MSI)
nit: this is just always 0
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/42077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide3528975be23585ce305f6cc909767b96af200f
Gerrit-Change-Number: 42077
Gerrit-PatchSet: 11
Gerrit-Owner: Brandon Breitenstein brandon.breitenstein@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tanu Malhotra tanu.malhotra@intel.com
Gerrit-Comment-Date: Tue, 29 Sep 2020 20:56:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment