Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44815 )
Change subject: util/ifdtool: Identify chipset without platform name ......................................................................
Patch Set 5:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44815/comment/95dfa1b4_13fa7d25 PS5, Line 168: guess_ifd_2_chipset
Is this a good time to get rid of the ifd 1 vs 2 distinction? It was pretty arbitrary and there are other platforms in between (ifd 1.5 if you will)
.
Agree with you, typically CNL onwards its very much IFWI 1.5 layout. We had some thought earlier to pass information from SoC Kconfig about type of IFWI layout rather modify IFD for each new SoC code. Finally as such check to make sure it also could able to cover newer chipsets.
It would be interesting to learn how Intel is doing the versioning / distinction here for their own tools
Honestly there is no common version control for the descriptor otherwise it would have easier to check only one parameter to make such decision.
I will try to dig this problem sometime next week and see if we have some more W/A to apply to fix this problem with Lynxpoint