Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use DEFAUL BARs_ADDRESS symbols ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig@525 PS14, Line 525: .bars
Why does the order matter? The new symbols don't have a prompt, hence […]
How about renaming this to `Kconfig.common`, and then moving this line after the `source "src/northbridge/*/*/Kconfig"` line? This will allow default values for options to be added in `src/northbridge/intel/common/Kconfig.common` (which I plan on doing someday)
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... File src/northbridge/intel/common/Kconfig.bars:
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... PS14, Line 3: DEFAULT_
It's not a default, it is the effective address that will be used. The […]
I used `FIXED_` as prefix in CB:43037 and it went in, so we could use it here too.