Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier.
Maximilian Brune has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87385?usp=email )
Change subject: sb/intel/lynxpoint: Add CFR objects for existing options ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
File src/southbridge/intel/lynxpoint/cfr.h:
https://review.coreboot.org/c/coreboot/+/87385/comment/4386ad69_ee57c7f5?usp... : PS2, Line 7: LYNXPOINT_CFR_H nit: I don't know if we have an actual guideline for include guard names, but we usually call them `_LYNXPOINT_H_`.
https://review.coreboot.org/c/coreboot/+/87385/comment/641576d3_663f9b33?usp... : PS2, Line 22: nit: On the other lines below, the indentation of the `}` is kept in sync with the other lines so maybe do the same in the 2 lines above.
https://review.coreboot.org/c/coreboot/+/87385/comment/21a91127_175c3107?usp... : PS2, Line 33: nit: Is there a reason for this indentation. (same for the two below).