Attention is currently required from: Paul Menzel, Christian Walter, Angel Pons, Lean Sheng Tan, David Milosevic.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72459 )
Change subject: mb/prodrive/atlas: retrieve and apply boot-options from SMMSTORE ......................................................................
Patch Set 9:
(43 comments)
File src/mainboard/prodrive/atlas/boot_options.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/c9796deb_761e5b81 PS9, Line 14: [OPT_HYPERTHREADING ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/10b84332_b31fe880 PS9, Line 15: [OPT_TURBOMODE ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/6bac9e5f_97dd76f3 PS9, Line 16: [OPT_CX ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/7831cde6_a8f4be16 PS9, Line 17: [OPT_CX_LIMIT ] = CX_LIMIT_C8, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/6c92b121_b572161e PS9, Line 19: [OPT_EE_TURBO ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/af648a2f_07fc05c2 PS9, Line 20: [OPT_LLC_DEADLINE ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/4fc657b8_8c5753e0 PS9, Line 21: [OPT_INTEL_VTX ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/d7ef3e2e_4ca50701 PS9, Line 22: [OPT_INTEL_VTD ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/760bd060_37085cf3 PS9, Line 23: [OPT_SECURE_BOOT ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/7207e1b0_92fa2159 PS9, Line 24: [OPT_PXE_RETRIES ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/018f4074_06503d38 PS9, Line 25: [OPT_PWR_G3 ] = PWR_G3_S5, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/44a5eba4_32281ba9 PS9, Line 26: [OPT_PCIE_SSC ] = PCIE_SSC_AUTO, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/78487a8c_b3ee4d1b PS9, Line 27: [OPT_PCIE_SRIS ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/6832ff42_644c59fd PS9, Line 28: [OPT_IBECC ] = false space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/80147673_cf99226c PS9, Line 33: [OPT_HYPERTHREADING ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/32aa6da2_7637c59c PS9, Line 34: [OPT_TURBOMODE ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/0639d7e0_02aef9ce PS9, Line 35: [OPT_CX ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/49ccbb4a_d7b95a0e PS9, Line 36: [OPT_CX_LIMIT ] = CX_LIMIT_C8, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/dbd7bb1d_8de1d41e PS9, Line 38: [OPT_EE_TURBO ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/1b0a8c39_ecc0bc3d PS9, Line 39: [OPT_LLC_DEADLINE ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/7ea2646e_a9fb8622 PS9, Line 40: [OPT_INTEL_VTX ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/4e7707a5_ab922953 PS9, Line 41: [OPT_INTEL_VTD ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/c570bda8_d5e06635 PS9, Line 42: [OPT_SECURE_BOOT ] = true, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/5b2305a7_562045ce PS9, Line 43: [OPT_PXE_RETRIES ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/7d3b3352_a82ccbbb PS9, Line 44: [OPT_PWR_G3 ] = PWR_G3_S5, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/f52b041b_296fd07b PS9, Line 45: [OPT_PCIE_SSC ] = PCIE_SSC_AUTO, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/b8ec11f7_164ac670 PS9, Line 46: [OPT_PCIE_SRIS ] = false, space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/cced501d_7cff5628 PS9, Line 47: [OPT_IBECC ] = false space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/c7cf380d_82d9eeb0 PS9, Line 51: static const char* option_name_lookup_table[OPT_END_ENUM] = { "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/750f4a3d_a2d66a31 PS9, Line 53: [OPT_HYPERTHREADING ] = "Hyperthreading", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/c101c161_797d449d PS9, Line 54: [OPT_TURBOMODE ] = "TurboMode", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/da706004_be0cf1b8 PS9, Line 55: [OPT_CX ] = "Cx", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/d020c27f_7278c753 PS9, Line 56: [OPT_CX_LIMIT ] = "CxLimit", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/ced1c07d_56f9edec PS9, Line 58: [OPT_EE_TURBO ] = "EnergyEfficientTurbo", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/3d5beead_1393ebcf PS9, Line 59: [OPT_LLC_DEADLINE ] = "LLCDeadline", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/5e9cf3f2_5496a73c PS9, Line 60: [OPT_INTEL_VTX ] = "VTX", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/b3c8b688_ce4faa01 PS9, Line 61: [OPT_INTEL_VTD ] = "VTD", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/c7289ae3_7f7aea8e PS9, Line 62: [OPT_SECURE_BOOT ] = "SecBoot", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/fff80167_fb474887 PS9, Line 63: [OPT_PXE_RETRIES ] = "PXERetries", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/854ec4af_11c31122 PS9, Line 64: [OPT_PWR_G3 ] = "PowerstateG3", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/a778984c_d56abaac PS9, Line 65: [OPT_PCIE_SSC ] = "PCIeSSC", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/e2713c96_83d4eb22 PS9, Line 66: [OPT_PCIE_SRIS ] = "PCIeSRIS", space prohibited before that close square bracket ']'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169734): https://review.coreboot.org/c/coreboot/+/72459/comment/ccc2ef08_102db500 PS9, Line 67: [OPT_IBECC ] = "IBECC" space prohibited before that close square bracket ']'