Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40261 )
Change subject: src/mb/google/volteer: workaround for GPIO PM on s0ix entry/exit
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40261/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40261/1/src/mainboard/google/voltee...
PS1, Line 44:
Shouldn't we comment that we don't really want this in the long run? And we should file a bug to rem […]
Yes, our long term goal should be to get rid of GPIO PM config being set to 0 altogether. This will have to be coordinated along with the update to cr50 which generates the right pulses. Yes, we should have a bug to remove this workaround for the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If522c82c0069a4bf5738beb73a2b4f11ed6f51d3
Gerrit-Change-Number: 40261
Gerrit-PatchSet: 1
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Wed, 08 Apr 2020 15:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment