Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 6:
(15 comments)
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... File Documentation/binaries/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 4: FSP
yes
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 4: f
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 5: premisses
Will double check with error correction... if it accepts, will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 9: deviation
thanks. will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 10: (similar to Intel's ME)
Will try to rephrase it.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 12: not the old
Have not thought about it... will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 20: Because family 17h does not support CAR, there's no FSP-T.
Ok.
Done
https://review.coreboot.org/c/coreboot/+/34662/1/Documentation/binaries/AMD_... PS1, Line 21: **FSP-M only reports memory**
Good idea.
Done
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 17: available.
Please use the full text width.
It was going beyond 76 characters... What is the limit for documentation?
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 21: > Family 17h does not require Cache as RAM and FSP-T calls are unsupported.
I think it does not need to be formatted as citation.
It was a way to separate context from bullet point... they were being placed on the same line. Will see if I can figure a different way.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 31: uses
use
will do.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 32: a
an
thanks...
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 41: intergers
inte*r*gers? that's a new datatype :P
lol typo.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 48: make call back
"call back" without the "make" sounds better
thanks.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/cavi... File Documentation/binaries/cavium/index.md:
PS6:
Are these placeholders added on purpose?
yes