Attention is currently required from: Angel Pons, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55224 )
Change subject: soc/intel/skylake: Auto-configure SerialIoDevMode UPD
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Nice idea.
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/55224/comment/1a9f3faf_4f3a3421
PS1, Line 186: When enabled, the `SerialIoDevMode` setting in chip config is useless.
It’d make it the other way around `EXPLICIT_SERIALIO_CFG`, so boards needing this have to select it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55224
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ec760e4dcc6b64e40c6ebd402642070f1de33a
Gerrit-Change-Number: 55224
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 13:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment