26 Nov
2019
26 Nov
'19
3:32 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36775 )
Change subject: mb/*/*{i440BX}: Enable console in bootblock ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... File src/mainboard/asus/p2b-ls/early_init.c:
https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... PS5, Line 46: #endif
Why guard it at all? […]
Meh, was looking at the wrong southbridge. `i82371eb/smbus.c` is the trouble maker.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87e5eb93c15a72f790739eff8395e7eecbf1eb04
Gerrit-Change-Number: 36775
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Branden Waldner scruffy99@gmail.com
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 23:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment