Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Andrey Petrov, Patrick Rudolph, EricR Lai.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60471 )
Change subject: drivers/intel/fsp: Creates map between FSP and coreboot console level
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60471/comment/82ca6aa6_578ff070
PS1, Line 12: Users to select HAVE_DEBUG_RAM_SETUP
HAVE_DEBUG_RAM_SETUP is merely used to hide/show the user-selectable
DEBUG_RAM_SETUP option. So it should be the caller of the mapping
function that selects it, e.g.
Callers have to select HAVE_DEBUG_RAM_SETUP config...
Patchset:
PS1:
Looks nice :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I398d576fad68a0d0fc931c175bbc04fcbc2e54ec
Gerrit-Change-Number: 60471
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 30 Dec 2021 12:54:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment