Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39866 )
Change subject: soc/intel/tigerlake: Add macros and SPD information for DDR4
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39866/2/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:
https://review.coreboot.org/c/coreboot/+/39866/2/src/soc/intel/tigerlake/inc...
PS2, Line 25: #define DDR4_DIMM_SLOTS (DIMMS_PER_CHANNEL * DDR4_CHANNELS)
nits: one more tab, align with above.
Done
https://review.coreboot.org/c/coreboot/+/39866/2/src/soc/intel/tigerlake/inc...
PS2, Line 29: /* Supports reading SPD using SMBus. */
nit: line these comments up with MEMORY_DOWN
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b565c3d71bbf437da64ac29597cc19e58f1b98a
Gerrit-Change-Number: 39866
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Mar 2020 17:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment