Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )
Change subject: mediatek/mt8183: Add DSI driver ......................................................................
Patch Set 25:
(5 comments)
https://review.coreboot.org/c/coreboot/+/31591/25//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31591/25//COMMIT_MSG@16 PS25, Line 16: mesaages messages
https://review.coreboot.org/c/coreboot/+/31591/25/src/soc/mediatek/mt8183/ds... File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/c/coreboot/+/31591/25/src/soc/mediatek/mt8183/ds... PS25, Line 81: > Consider changing to ">=" for consistency
https://review.coreboot.org/c/coreboot/+/31591/25/src/soc/mediatek/mt8183/ds... PS25, Line 93: lanes); Can be moved to the previous line
https://review.coreboot.org/c/coreboot/+/31591/25/src/soc/mediatek/mt8183/ds... PS25, Line 295: printk(BIOS_ERR, "HFP less than d-phy, FPS will under 60Hz\n"); Exceeds 80 columns
https://review.coreboot.org/c/coreboot/+/31591/25/src/soc/mediatek/mt8183/ds... PS25, Line 302: printk(BIOS_ERR, "HFP less than d-phy, FPS will under 60Hz\n"); Exceeds 80 columns