Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40290 )
Change subject: util/nvramtool: Remove 2nd initialization ......................................................................
util/nvramtool: Remove 2nd initialization
'result' is already defined as 'unsigned long long result = 0;' so no need to re-write 'result = 0;'.
Change-Id: Ie897453fb5e7b09af755ce8d61ee8e80943ffc1c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40290 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/nvramtool/cmos_lowlevel.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/util/nvramtool/cmos_lowlevel.c b/util/nvramtool/cmos_lowlevel.c index eadda62..32406ec 100644 --- a/util/nvramtool/cmos_lowlevel.c +++ b/util/nvramtool/cmos_lowlevel.c @@ -121,7 +121,6 @@ unsigned char value;
assert(!verify_cmos_op(bit, length, e->config)); - result = 0;
if (e->config == CMOS_ENTRY_STRING) { int strsz = (length + 7) / 8 + 1;