Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO
......................................................................
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review+1
Patch Set 1:
correct, neither of these devices have serial output without additional hardware
I wonder serial output is actually coming from the IT8772F SIO
Just checked internet pictures, the chromebook has a SMSC MEC1310-NU and the chromebox has an ITE IT8772F on the board. I guess this is just debug code as there is no LPC47N207 on the board, and that SuperIO is rather old (saw it being used on a Pentium 4 Northwood mainboard).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37183
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0eda4aee2cbb114bde33e862940a64675469693d
Gerrit-Change-Number: 37183
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 19:00:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment