Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27277 )
Change subject: soc/amd/common: Fix AmdLateRunApTask()
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Been a little busy myself... I'll give you a +2 assuming your answer to my question being a yes.
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/agesawra...
File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/27277/5/src/soc/amd/common/block/pi/agesawra...
PS5, Line 356: amd_late_run_ap_task
That prefix agesawrapper_ was stupid in the first place and followups shall remove the rest. […]
I would tend to agree. Are you planning on doing the followups that you mentioned?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dad64b955b53bd19363737665235f95aa3d451e
Gerrit-Change-Number: 27277
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Feb 2019 20:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment
