[coreboot-gerrit] Change in coreboot[master]: lib/crc_byte: Add CRC32 implementation

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37753 )

Change subject: lib/crc_byte: Add CRC32 implementation
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

I don't really understand the double negation thing you're doing there, but assuming you have a good reason for it, LGTM.

https://review.coreboot.org/c/coreboot/+/37753/1/src/include/crc_byte.h 
File src/include/crc_byte.h:

https://review.coreboot.org/c/coreboot/+/37753/1/src/include/crc_byte.h@52 
PS1, Line 52: ~0;
Why the negation here and for the result? Does it not work when you just start with 0? If so, do we need to update the documentation above that suggests you should start with 0?