I don't really understand the double negation thing you're doing there, but assuming you have a good reason for it, LGTM.

Patch set 1:Code-Review +2

View Change

1 comment:

• File src/include/crc_byte.h:

  • Patch Set #1, Line 52: ~0;

    Why the negation here and for the result? Does it not work when you just start with 0? If so, do we need to update the documentation above that suggests you should start with 0?

To view, visit change 37753. To unsubscribe, or for help writing mail filters, visit settings.