Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3: Code-Review-1
I don't think there is much to gain from doing this, or am I mistaken?
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL,
What if another thermal device ID appears that can be handled by the same driver?
Just a little code clean up. If there appears another device ID as you said, then we can revert/undo this change, because it's not much work. As long as there is only this device ID I see no reason why we should use .devices instead of .device.
It is also used at other places, so it just makes sense moving to .device to keep the consistency. Otherwise we should move everything else to .devices.