Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47305 )
Change subject: mainboard/ocp/tiogapass: Add xeon_sp pch.asl
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47305/1/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/47305/1/src/mainboard/ocp/tiogapass...
PS1, Line 18: Scope (_SB.PC00)
Why not add this scope in pch. […]
I thought about it, but found the other intel chipsets and mainboards set the scope in the mainboard dsdt, so I kept it that way. In theory, the PC00 scope could be different per mainboard, but that is very unlikely.
See CB:47304 for the deltalake change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22ee9d325888808a9c775ecee0591b661e2bba4e
Gerrit-Change-Number: 47305
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: javiergalindo@sysproconsulting.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 18:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment