Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47298 )
Change subject: soc/intel/xeon_sp: Change the return type of get_iio_stack_info() ......................................................................
Patch Set 1:
(1 comment)
Yes, I didn't like the introduction of that return type. I'd also like to de-dup this function, but they are slightly different and haven't confirmed the change for skx. This will need a rebase since several functions have moved out of soc_util.c
https://review.coreboot.org/c/coreboot/+/47298/1/src/soc/intel/xeon_sp/chip_... File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/47298/1/src/soc/intel/xeon_sp/chip_... PS1, Line 437: pci64bit_alloc_flag It could be called it here. No need for a flag variable.