[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51374 )

Change subject: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87
......................................................................

Patch Set 9:

(2 comments)

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/51374/comment/54922833_5bd5a860 
PS8, Line 527:  2. Set SF_MASK_1 = ((1 << SFWayCnt) - 1) - ((1 << data_ways) - 1)
> This can be simplified further to remove 1 subtraction: […]

Ack

https://review.coreboot.org/c/coreboot/+/51374/comment/1dd48e05_eab72465 
PS8, Line 532: mov	%al, %cl
             : 	mov	$0x01, %eax
             : 	shl	%cl, %eax
             : 	subl	$0x01, %eax /* contains ((1 << SFWayCnt) - 1) */
             : 	mov	%bl, %cl
             : 	mov	$0x01, %ebx
             : 	shl	%cl, %ebx
             : 	subl	$0x01, %ebx /* contains ((1 << data_ways) - 1) */
             : 	sub	%ebx, %eax /* contains SF mask */
> Oops, yes, I mixed up the order of registers in that line, you figured out what I meant 😉 Right, wi […]

Ack