Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't enable MAX98357A in dt ......................................................................
Patch Set 7:
(1 comment)
Patch Set 7:
(1 comment)
CB:37909 undoes what is done in this CL. Can we just drop this?
This fixes an immediate issue while the follow up is the proposed 'proper fix' which is more invasive. As I explained to Dan already, here we fix the issue while in the follow up we propose the more long term maintainable strategy on detailing with the current assumptions in baseboard.
https://review.coreboot.org/c/coreboot/+/37822/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37822/7/src/mainboard/google/hatch/... PS7, Line 5: if !BOARD_GOOGLE_PUFF
This should not be required. The linker drops unused sections.
That's incorrect, and if you see the history of Dan asking me to change the commit message from before may give insight.
The issue here is that the baseboard is defining a devicetree chip node and this is why it gets instantiated. The devil is in the detail here