build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo: Add ThinkPad T431s ......................................................................
Patch Set 1:
(16 comments)
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/romstage.... File src/mainboard/lenovo/t431s/romstage.c:
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/romstage.... PS1, Line 62: void mainboard_get_spd(spd_raw_data *spd, bool id_only) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... File src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex:
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 1: 92 11 0b 03 04 00 00 01 03 52 01 08 0a 00 80 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 2: 6e 78 6e 32 6e 11 18 81 20 08 3c 3c 00 f0 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 3: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 65 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b6 3b trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 9: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace
https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsu... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 trailing whitespace