Attention is currently required from: Furquan Shaikh, Martin Roth, Andy Yeh, Rizwan Qureshi, Karthik Ramasubramanian. Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50261 )
Change subject: mb/google/dedede/var/magolor: Select camera module based on SSFC value ......................................................................
Patch Set 10:
(6 comments)
File src/mainboard/google/dedede/variants/magolor/camera_config.c:
PS9:
I think most of this can be handled in the overridetree.cb. Please see my comments in that file.
Done
https://review.coreboot.org/c/coreboot/+/50261/comment/e03f5bca_a02cac21 PS9, Line 47: static struct drivers_intel_mipi_camera_config ovti5675_driver_info = {
Ah you are right. […]
https://review.coreboot.org/c/coreboot/+/50261/10/src/mainboard/google/deded...
@karthik/@Furquan As 0 will be read from the SSFC value when SSFC is not configured Choosing the OVTI5675 as default camera when no value is set in SSFC, as Acer also wants to keep the OVT5675 as default camera. Please let us know if we still need camera_device_update.
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50261/comment/cff88035_076e1a2c PS9, Line 117: chip drivers/intel/mipi_camera
The registers here seem to be the same for both cameras used for Magolor. […]
Done
https://review.coreboot.org/c/coreboot/+/50261/comment/adfe00a7_1e4b79e9 PS9, Line 205: chip drivers/intel/mipi_camera
Also enable/select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG
Done
https://review.coreboot.org/c/coreboot/+/50261/comment/b035c429_eba1e3fc PS9, Line 246: chip drivers/intel/mipi_camera
Looks like the VCM is the same for both cameras. So, this can stay as is in the override tree.
Done
https://review.coreboot.org/c/coreboot/+/50261/comment/a59ae34b_86d40c7d PS9, Line 258: chip drivers/intel/mipi_camera
Looks like NVM is also the same for both cameras. So, this can stay as is in the override tree.
Done