Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31606 )
Change subject: libpayload: cbfs: Require input size and output size for cbfs_decompress ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor... File payloads/libpayload/libcbfs/cbfs_core.c:
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/libcbfs/cbfs_cor... PS1, Line 331: len = MIN(srcn, dstn);
Taking your 'nit' literally, I think we don't have a strong reason to remove it. […]
It would just separate error behavior from expected behavior better. If you want to preserve the partial decompression thing, how about
len = MIN(srcn, dstn); memcpy(dst, src, len); if (len < srcn) return 0; /* treat not enough buffer space to "decompress" as error */ return len;
? That's in line with the other two (they also return 0 for partial decompression).